Skip to content

Fix order-alphabetical rule message #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2016
Merged

Fix order-alphabetical rule message #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/csslint-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ CSSLint.addRule({
expectedProperties = properties.sort().join(",");

if (currentProperties !== expectedProperties) {
reporter.report("Rule doesn't have all its properties in alphabetical ordered.", event.line, event.col, rule);
reporter.report("Rule doesn't have all its properties in alphabetical order.", event.line, event.col, rule);
}
};

Expand Down
2 changes: 1 addition & 1 deletion dist/csslint-rhino.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8460,7 +8460,7 @@ CSSLint.addRule({
expectedProperties = properties.sort().join(",");

if (currentProperties !== expectedProperties) {
reporter.report("Rule doesn't have all its properties in alphabetical ordered.", event.line, event.col, rule);
reporter.report("Rule doesn't have all its properties in alphabetical order.", event.line, event.col, rule);
}
};

Expand Down
4 changes: 2 additions & 2 deletions dist/csslint-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3065,14 +3065,14 @@ background: -o-linear-gradient(top, #1e5799 ,#2989d8 ,#207cca ,#7db9e8 );
var result = CSSLint.verify("li { z-index: 2; color: red; }", { "order-alphabetical": 1 });
Assert.areEqual(1, result.messages.length);
Assert.areEqual("warning", result.messages[0].type);
Assert.areEqual("Rule doesn't have all its properties in alphabetical ordered.", result.messages[0].message);
Assert.areEqual("Rule doesn't have all its properties in alphabetical order.", result.messages[0].message);
},

"Rules with prefixed properties not in alphabetical order (without the prefix) should result in a warning": function() {
var result = CSSLint.verify("li { -moz-transition: none; -webkit-box-shadow: none; }", { "order-alphabetical": 1 });
Assert.areEqual(1, result.messages.length);
Assert.areEqual("warning", result.messages[0].type);
Assert.areEqual("Rule doesn't have all its properties in alphabetical ordered.", result.messages[0].message);
Assert.areEqual("Rule doesn't have all its properties in alphabetical order.", result.messages[0].message);
},

"Rules with properties in alphabetical order should not result in a warning": function() {
Expand Down
2 changes: 1 addition & 1 deletion dist/csslint-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8456,7 +8456,7 @@ CSSLint.addRule({
expectedProperties = properties.sort().join(",");

if (currentProperties !== expectedProperties) {
reporter.report("Rule doesn't have all its properties in alphabetical ordered.", event.line, event.col, rule);
reporter.report("Rule doesn't have all its properties in alphabetical order.", event.line, event.col, rule);
}
};

Expand Down
2 changes: 1 addition & 1 deletion dist/csslint-wsh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8460,7 +8460,7 @@ CSSLint.addRule({
expectedProperties = properties.sort().join(",");

if (currentProperties !== expectedProperties) {
reporter.report("Rule doesn't have all its properties in alphabetical ordered.", event.line, event.col, rule);
reporter.report("Rule doesn't have all its properties in alphabetical order.", event.line, event.col, rule);
}
};

Expand Down
2 changes: 1 addition & 1 deletion dist/csslint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8460,7 +8460,7 @@ CSSLint.addRule({
expectedProperties = properties.sort().join(",");

if (currentProperties !== expectedProperties) {
reporter.report("Rule doesn't have all its properties in alphabetical ordered.", event.line, event.col, rule);
reporter.report("Rule doesn't have all its properties in alphabetical order.", event.line, event.col, rule);
}
};

Expand Down
2 changes: 1 addition & 1 deletion src/rules/order-alphabetical.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ CSSLint.addRule({
expectedProperties = properties.sort().join(",");

if (currentProperties !== expectedProperties) {
reporter.report("Rule doesn't have all its properties in alphabetical ordered.", event.line, event.col, rule);
reporter.report("Rule doesn't have all its properties in alphabetical order.", event.line, event.col, rule);
}
};

Expand Down
4 changes: 2 additions & 2 deletions tests/rules/order-alphabetical.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
var result = CSSLint.verify("li { z-index: 2; color: red; }", { "order-alphabetical": 1 });
Assert.areEqual(1, result.messages.length);
Assert.areEqual("warning", result.messages[0].type);
Assert.areEqual("Rule doesn't have all its properties in alphabetical ordered.", result.messages[0].message);
Assert.areEqual("Rule doesn't have all its properties in alphabetical order.", result.messages[0].message);
},

"Rules with prefixed properties not in alphabetical order (without the prefix) should result in a warning": function() {
var result = CSSLint.verify("li { -moz-transition: none; -webkit-box-shadow: none; }", { "order-alphabetical": 1 });
Assert.areEqual(1, result.messages.length);
Assert.areEqual("warning", result.messages[0].type);
Assert.areEqual("Rule doesn't have all its properties in alphabetical ordered.", result.messages[0].message);
Assert.areEqual("Rule doesn't have all its properties in alphabetical order.", result.messages[0].message);
},

"Rules with properties in alphabetical order should not result in a warning": function() {
Expand Down