Skip to content

Removed all unused services#95

Draft
Samartha-m3 wants to merge 2 commits intostagingfrom
prune
Draft

Removed all unused services#95
Samartha-m3 wants to merge 2 commits intostagingfrom
prune

Conversation

@Samartha-m3
Copy link
Copy Markdown
Contributor

@Samartha-m3 Samartha-m3 commented Jan 5, 2026

Warning

major services were removed as part of this prune

Removal tree is mentioned below in nested list format

  • .adminjs: unused before prune
  • src/controllers/ToolsCatalogController.ts: unused before prune
  • views/pages/review-dashboard.ejs: to be rewritten for new validation
    • POST /approve: No longer called by review dashboard
      • ViewController.approveAll: No longer used by /approve route
      • ValidationManager: No longer used by ViewController
        removed src/services
    • POST /reject-all: No longer called by review dashboard

@Samartha-m3 Samartha-m3 changed the base branch from main to staging January 5, 2026 22:03
Copy link
Copy Markdown
Member

@awhicks awhicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just found this and thought I had already responded.

Lets hold off on getting rid of the Ontology pieces, we might still use some of that/want to keep it around as a base for that continuing work.

We may also want to keep the services, as some of the LTI validation will be retained, even if we need to reorganize how it works internally, the access to the validator container is useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants