fix semantics of updating inactive terms

Author: EarthenSky

src/officers/crud.py

@@ -216,6 +216,7 @@ async def create_new_officer_term(
     # if new_officer_term.position not in OfficerPosition.position_list():
     #     raise HTTPException(status_code=500)
 
+    # when creating a new position, assign a default end date if one exists
     position_length = OfficerPosition.length_in_semesters(new_officer_term.position)
     if position_length is not None:
         new_officer_term.end_date = semesters.step_semesters(

src/officers/urls.py

@@ -324,23 +324,20 @@ async def update_term(
         raise HTTPException(status_code=401, detail="must have website admin permissions to update another user")
 
     if (
-        not utils.is_active_term(old_officer_term)
+        not utils.is_past_term(old_officer_term)
         and not await WebsiteAdmin.has_permission(db_session, session_computing_id)
     ):
-        raise HTTPException(status_code=401, detail="only website admin can update a non-active term")
+        raise HTTPException(status_code=401, detail="only website admins can update past terms")
 
     # NOTE: Only admins can write new versions of position, start_date, and end_date.
     if (
-        (
-            officer_term_upload.position != old_officer_term.position
-            or officer_term_upload.start_date != old_officer_term.start_date
-            or officer_term_upload.end_date != old_officer_term.end_date
-        )
-        and not await WebsiteAdmin.has_permission(db_session, session_computing_id)
-    ):
+        officer_term_upload.position != old_officer_term.position
+        or officer_term_upload.start_date != old_officer_term.start_date
+        or officer_term_upload.end_date != old_officer_term.end_date
+    ) and not await WebsiteAdmin.has_permission(db_session, session_computing_id):
         raise HTTPException(status_code=401, detail="Non-admins cannot modify position, start_date, or end_date.")
 
-    # TODO: log all important changes just to a .log file
+    # TODO: log all important changes to a .log file
     success = await officers.crud.update_officer_term(
         db_session,
         officer_term_upload.to_officer_term(term_id, old_officer_term.computing_id)

src/utils.py

@@ -43,6 +43,15 @@ def is_active_term(term: OfficerTerm) -> bool:
         )
     )
 
+def is_past_term(term: OfficerTerm) -> bool:
+    """Any term which has concluded"""
+    return (
+        # an officer with no end date is current
+        term.end_date is not None
+        # if today is past the end date, it's a past term
+        and datetime.today() > term.end_date
+    )
+
 def is_valid_phone_number(phone_number: str) -> bool:
     return (
         len(phone_number) == 10