chore: code clean up

Author: jbriones1

src/elections/crud.py

@@ -1,12 +1,13 @@
+from collections.abc import Sequence
+
 import sqlalchemy
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from elections.tables import Election, NomineeApplication, NomineeInfo
 from officers.types import OfficerPositionEnum
 
 
-async def get_all_elections(db_session: AsyncSession) -> list[Election]:
-    # TODO: can this return None?
+async def get_all_elections(db_session: AsyncSession) -> Sequence[Election]:
     election_list = (await db_session.scalars(
         sqlalchemy
         .select(Election)
@@ -55,7 +56,7 @@ async def get_all_registrations_of_user(
     db_session: AsyncSession,
     computing_id: str,
     election_slug: str
-) -> list[NomineeApplication] | None:
+) -> Sequence[NomineeApplication] | None:
     registrations = (await db_session.scalars(
         sqlalchemy
         .select(NomineeApplication)
@@ -86,7 +87,7 @@ async def get_one_registration_in_election(
 async def get_all_registrations_in_election(
     db_session: AsyncSession,
     election_slug: str,
-) -> list[NomineeApplication] | None:
+) -> Sequence[NomineeApplication] | None:
     registrations = (await db_session.scalars(
         sqlalchemy
         .select(NomineeApplication)

src/elections/tables.py

@@ -1,4 +1,4 @@
-from datetime import date, datetime
+from datetime import datetime
 
 from sqlalchemy import (
     DateTime,
@@ -7,10 +7,8 @@
     String,
     Text,
 )
-from sqlalchemy.ext.hybrid import hybrid_method, hybrid_property
+from sqlalchemy.ext.hybrid import hybrid_property
 from sqlalchemy.orm import Mapped, mapped_column
-from sqlalchemy.orm.attributes import set_attribute
-from sqlalchemy.util import hybridproperty
 
 from constants import (
     COMPUTING_ID_LEN,

tests/integration/test_elections.py

@@ -1,12 +1,11 @@
 import asyncio
-import json
 from datetime import datetime, timedelta
 
 import pytest
 from httpx import ASGITransport, AsyncClient
 
 from src import load_test_db
-from src.auth.crud import create_user_session, get_computing_id, update_site_user
+from src.auth.crud import create_user_session
 from src.database import SQLALCHEMY_TEST_DATABASE_URL, DatabaseSessionManager
 from src.elections.crud import (
     # election crud