First Elections PR #63

EarthenSky · 2024-08-09T22:54:56Z

elections PR, woo!

src/elections/models.py

…omineeSepech -> NomineeApplication, changed ForeignKeyConstraints to ForeignKey

…r a user is a current elections officer

EarthenSky

I'll do another review round after, but 99% looks good!

src/alembic/versions/243190df5588_create_election_tables.py

src/elections/tables.py

src/elections/urls.py

src/elections/crud.py

src/elections/tables.py

src/permission/types.py

src/elections/crud.py

… style check

…ection()

…ey has been deprecated

…lected changes across urls.py

…n the project. Changed database.DBSession -> AsyncSession to match other crud functions.

DerpyWasHere · 2025-01-13T06:02:19Z

Alright, brief high level summary. This PR introduces the following:

CRUD functions for creating, getting, updating, and deleting elections.
SQLAlchemy tables for elections, nominees, and nominee applications (election paired with nominee)
Endpoints for creating, deleting, and updating elections.

This still needs to introduce/do the following:

Endpoint for getting/viewing an election's data (public and private).
Test user validation.

I'll work on these in my next PR.

As of this comment, all of the above comments should have been addressed.

src/elections/tables.py

…e -> end_datetime in elections module.

EarthenSky

Oops, since I made this PR originally I can't request changes. However, consider this "request changes".

The biggest issue is the uniqueness of the slug, the rest are medium level.

Mostly the logic is good!

src/elections/urls.py

src/alembic/versions/243190df5588_create_election_tables.py

src/elections/urls.py

src/elections/crud.py

src/elections/urls.py

src/main.py

src/permission/types.py

EarthenSky · 2025-04-07T03:50:27Z

This PR creates tables for elections and nominees, while introducing tested endpoints just for the elections (C,R,U,D)

DerpyWasHere added 3 commits August 9, 2024 11:12

Added elections model to alembic/env.py

d67b000

Added election tables revision to alembic

905170b

Initial elections model implementation

7cb496c

EarthenSky linked an issue Aug 9, 2024 that may be closed by this pull request

Elections Info #25

Open

EarthenSky commented Aug 9, 2024

View reviewed changes

src/elections/models.py Outdated Show resolved Hide resolved

DerpyWasHere added 5 commits August 10, 2024 08:37

Redid revision, added position column to NomineeAplication, renamed N…

8b06dda

…omineeSepech -> NomineeApplication, changed ForeignKeyConstraints to ForeignKey

Added ElectionOfficer class, created has_permission() to check whethe…

b5103ca

…r a user is a current elections officer

Changed date to be nonnull, officer_id in alembic revision

b579e08

Removed unique constraint on officer_id

c89e659

Removed unique constraint on officer_id, removed nullability from date

117611a

EarthenSky changed the title ~~Issue 25~~ First Elections PR Aug 18, 2024

DerpyWasHere added 4 commits August 29, 2024 20:42

properly handled session validation on create_elections

3aded13

created create_election stub

fc8def5

added elections router to main

d9b8e52

Working commit containing fns to create, delete, and update elections

e239b9b

DerpyWasHere marked this pull request as ready for review September 27, 2024 01:48

EarthenSky added 4 commits October 2, 2024 21:47

Merge branch 'main' into dev-issue-25

8bf5dcb

switch from models to tables

06fe816

fix small import bug

82685ef

fix past alembic migration

0c299d2

EarthenSky commented Oct 3, 2024

View reviewed changes

src/elections/crud.py Outdated Show resolved Hide resolved

EarthenSky commented Oct 3, 2024

View reviewed changes

src/elections/crud.py Outdated Show resolved Hide resolved