Skip to content

Finalize Officer Terms #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 9, 2024
Merged

Finalize Officer Terms #86

merged 16 commits into from
Dec 9, 2024

Conversation

@EarthenSky
Copy link
Collaborator

@EarthenSky EarthenSky commented Sep 8, 2024 •
edited
Loading

Close #84

Features

  • an officer may have multiple terms at once
  • an officer may not update a past exec term

@EarthenSky
Copy link
Collaborator Author

EarthenSky commented Oct 3, 2024

TODO: why was I measuring exec term length?

@EarthenSky
Copy link
Collaborator Author

EarthenSky commented Dec 9, 2024

TODO: why was I measuring exec term length?

Default end_date for create_new_officer_term

@EarthenSky EarthenSky marked this pull request as ready for review December 9, 2024 06:30
@EarthenSky
Copy link
Collaborator Author

EarthenSky commented Dec 9, 2024

I did some sanity checks; it seems to be working reasonably fine! Still lots of cleaning for this module, boy did I overcomplicate it...

@EarthenSky
Copy link
Collaborator Author

EarthenSky commented Dec 9, 2024

"move fast and break things"

@EarthenSky EarthenSky merged commit 27907f7 into main Dec 9, 2024
3 checks passed
@EarthenSky EarthenSky deleted the dev-84 branch December 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test officer term semantics

2 participants

@EarthenSky