Implement testing workflow changes #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattyTheHacker
added
deployment
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR isolates testing workflow changes to streamline the review process.
- Updates test dependencies and adds coverage reporting configuration in pyproject.toml
- Refactors environment variable parsing and validation in config.py
- Modifies the GitHub workflow to run tests with coverage and integrates Codecov upload steps
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updated test dependencies and added coverage report configuration. |
| config.py | Improved environment variable handling and validation logic. |
| .github/workflows/check-build-deploy.yaml | Modified test commands and added Codecov actions for test reporting. |
Comments suppressed due to low confidence (1)
config.py:645
- The error message contains an extra 'SEND_' in the environment variable name; consider renaming it to 'SEND_GET_ROLES_REMINDERS_DELAY' for clarity.
"SEND_SEND_GET_ROLES_REMINDERS_DELAY must be longer than or equal to 1 day."
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
MattyTheHacker
force-pushed
the
testing-workflow-changes
branch
from
23f2b5a to
2567f2b
Compare
MattyTheHacker
added
the
sync
CarrotManMatt
requested changes
Jun 13, 2025
Co-authored-by: Matt Norton <[email protected]> Signed-off-by: Matty Widdop <[email protected]>
…#508) Signed-off-by: Holly <[email protected]> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Matty Widdop <[email protected]>
MattyTheHacker
force-pushed
the
testing-workflow-changes
branch
from
a8c845c to
45dac3f
Compare
cssbhamdev
added
conflict
Contributor
|
This pull request has a merge conflict with the base branch! Please resolve the conflict manually, remove the conflict label and re-add the filter label (if applicable). |
MattyTheHacker
added
sync
CarrotManMatt
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR pulled out from #516 just to reduce the load in that PR, this one focusing on the workflow changes