Fix parsing failure for "Running Course" activities containing actionSummary#91
Open
jiaweixiao wants to merge 1 commit intoCTHRU:masterfrom
Open
Fix parsing failure for "Running Course" activities containing actionSummary#91jiaweixiao wants to merge 1 commit intoCTHRU:masterfrom
actionSummary#91jiaweixiao wants to merge 1 commit intoCTHRU:masterfrom
Conversation
…ties Running course activities include an 'actionSummary' JSON block at the end of the raw telemetry data in the 'attribute' field. This non-CSV content causes the HiTrack parser to fail. This commit adds a regex filter to remove this metadata block before saving/parsing the HiTrack data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a bug(#90) where activities recorded as Running Courses (structured workouts) failed to convert.
Changes
HiJson._parse_activityto include a regex cleaning step.hitrack_datais now stripped of theactionSummary=...block often found at the end of theattributestring in Huawei Health exports.tp=prefixed CSV lines are passed to theHiTrackFileparser.Reasoning:
Huawei appends workout summaries to the telemetry data in certain activity types. Since our
HiTrackFileparser relies oncsv.readerto iterate through telemetry records, encountering a raw JSON-like string at the end of the file causes index errors or parsing exceptions. By stripping this out during the JSON-to-HiTrack extraction phase, we maintain compatibility with the existing parsing logic.