address code review

Author: mateusfavarin

include/ctr/macros.h

@@ -17,6 +17,20 @@ typedef int16_t  s16;
 typedef uint8_t  u8;
 typedef int8_t   s8;
 
+#define U32_MAX UINT32_MAX
+#define S32_MAX INT32_MAX
+#define U16_MAX UINT16_MAX
+#define S16_MAX INT16_MAX
+#define U8_MAX UINT8_MAX
+#define S8_MAX INT8_MAX
+
+#define U32_MIN UINT32_MIN
+#define S32_MIN INT32_MIN
+#define U16_MIN UINT16_MIN
+#define S16_MIN INT16_MIN
+#define U8_MIN UINT8_MIN
+#define S8_MIN INT8_MIN
+
 #define AugReview 805
 #define SepReview 903
 #define UsaRetail 926

rewrite/src/exe/coll.c

@@ -416,7 +416,7 @@ static void _COLL_TestLeaf_Quadblock(const Quadblock* quadblock, CollDCache* cac
 #endif
         COLL_TestTriangle(cache, &cache->quadblockCollVertices[5], &cache->quadblockCollVertices[6], &cache->quadblockCollVertices[2]);
 #ifndef FIX_CTR_BUG
-    cache->currTriangleIndex = 6;
+    cache->currTriangleIndex = 6; // not a bug, but unnecessary assignment...
 #endif
         if (cache->quadblockThirdIndex != cache->quadblockFourthIndex)
         {
@@ -437,7 +437,7 @@ static void _COLL_TestLeaf_Quadblock(const Quadblock* quadblock, CollDCache* cac
     cache->currTriangleIndex = 0;
     COLL_TestTriangle(cache, &cache->quadblockCollVertices[0], &cache->quadblockCollVertices[1], &cache->quadblockCollVertices[2]);
 #ifndef FIX_CTR_BUG
-    cache->currTriangleIndex = 1;
+    cache->currTriangleIndex = 1; // not a bug, but unnecessary assignment...
 #endif
     if (cache->quadblockThirdIndex != cache->quadblockFourthIndex)
     {

rewrite/src/tests/test.c

@@ -55,7 +55,7 @@ u32 PatchFunction_Beg(u32* address, const char* funcName)
     s_nameTestedFunc = funcName;
     __asm__ volatile("move $k1, %0" : : "r"(addr));
 
-    u32 index = UINT32_MAX;
+    u32 index = U32_MAX;
     const u32 funcCount = ARR_LEN(s_functions);
     for (u32 i = 0; i < funcCount; i++)
     {
@@ -73,7 +73,7 @@ u32 PatchFunction_Beg(u32* address, const char* funcName)
 
 void PatchFunction_End(u32 index)
 {
-    if (index == UINT32_MAX) { return; }
+    if (index == U32_MAX) { return; }
     *(s_functions[index].address) = s_functions[index].firstNewInst;
     *(s_functions[index].address + 1) = s_functions[index].secondNewInst;
     FlushCache();