[COLL] first function decompiled #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #ifdef TEST_COLL_IMPL | ||
|
|
||
| void TEST_COLL_ProjectPointToEdge(const SVec3* v1, const SVec3* v2, const SVec3* point, const SVec3* ret) |
Contributor
There was a problem hiding this comment.
For pure functions, this template is probably unchanging. I wonder if there's a way to automate the test functions with macros.
| gte_loadSVec(edge.v, GTE_VECTOR_0); | ||
| s32 edgeDot, pointDot; | ||
| gte_dotProduct(&edgeDot, GTE_ROW_INDEX_0, GTE_MATRIX_ROT, GTE_VECTOR_0); | ||
| gte_readMac(&pointDot, GTE_MAC_2); |
Contributor
There was a problem hiding this comment.
Something I notice when I read this, is that I don't have any reason to believe/expect that the output of gte_dotProduct to be in GTE_MAC_2. Do we have a comment on that macro?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.