-
Notifications
You must be signed in to change notification settings - Fork 46
[COLL] Barycentric Test function decompiled #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| /* Naughty Dog bug: their hand written assembly code | ||
| forgets to check beta == -1, creating false collisions */ | ||
| #ifdef FIX_CTR_BUGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big appreciate
| lw $s1, 4($sp) | ||
| lw $s0, 0($sp) | ||
| addiu $sp, $sp, 44 | ||
| .endm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this stuff is in another .s file, can you #include from an .s file to have these macros?
| #include <ctr/math.h> | ||
|
|
||
| typedef struct Color | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??? why not just uint8_t?
|
|
||
| #define nullptr ((void *) 0) | ||
| #define force_inline static inline __attribute__((always_inline)) | ||
| #define force_inline static inline __attribute__((always_inline)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is static necessary?
No description provided.