Skip to content

Conversation

@mateusfavarin
Copy link
Collaborator

No description provided.


/* Naughty Dog bug: their hand written assembly code
forgets to check beta == -1, creating false collisions */
#ifdef FIX_CTR_BUGS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big appreciate

lw $s1, 4($sp)
lw $s0, 0($sp)
addiu $sp, $sp, 44
.endm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this stuff is in another .s file, can you #include from an .s file to have these macros?

#include <ctr/math.h>

typedef struct Color
{
Copy link
Contributor

@TheUbMunster TheUbMunster Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? why not just uint8_t?


#define nullptr ((void *) 0)
#define force_inline static inline __attribute__((always_inline))
#define force_inline static inline __attribute__((always_inline))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is static necessary?

@mateusfavarin mateusfavarin merged commit 2cfeaa1 into main Sep 23, 2025
1 check passed
@mateusfavarin mateusfavarin deleted the coll_decomp branch September 23, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants