Conversation
kwitaszczyk
left a comment
There was a problem hiding this comment.
chericat fails to compile with this change:
===> Patching for chericat-0.0.d20240717
===> Applying FreeBSD patches for chericat-0.0.d20240717 from /zdata/repos/cheribsd-ports/chericat-update-20240724/sysutils/chericat/files
1 out of 1 hunks failed--saving rejects to Makefile.rej
===> FAILED Applying FreeBSD patch-Makefile
===> FAILED to apply cleanly FreeBSD patch(es) patch-Makefile
*** Error code 1
We should remove files/patch-Makefile and apply 9081151 directly in the chericat project.
…e need to generate a new patch. Also ABI check has been renamed to MACHINE_ABI
|
The patch is needed because the cheribsd-ports build infrastructure already includes the standard include and lib in CFLAGS and LDFLAGS, but outside of the build framework we do need to explicitly add them in the makefile. So I have generated a new patch based on the version used here. |
Yes, we should not get rid of this patch. My suggestion was to keep the change but make it directly in chericat rather than maintain this patch in CheriBSD ports. Can we move it there? Additionally, with the patch in ports, anytime someone forks your chericat repository on CheriBSD, they would have to apply the patch themselves. |
|
We've had an offline discussion that the chericat repository with the patch wouldn't build. That's because the ports build system automatically adds I would suggest two things:
|
|
The makefile has been updated in CTSRD-CHERI/chericat#49 |
Update the version to the latest (2024-07-17) commit.