mmap: limit PROT_CAP and PROT_NO_CAP to CHERI ABIs#2567
Merged
brooksdavis merged 1 commit intodevfrom Feb 20, 2026
Merged
Conversation
jrtc27
reviewed
Feb 19, 2026
jrtc27
reviewed
Feb 19, 2026
Contributor
|
I think this should be fine, I'm trying to rework |
brooksdavis
force-pushed
the
no-prot-cap-for-non-cheri
branch
from
61a517c to
c042509
Compare
Declaring them and using them in _PROT_ALL means mmap would fail in rtld and risked in correct autoconf style checks for PROT_CAP on systems that otherwise don't support it.
brooksdavis
force-pushed
the
no-prot-cap-for-non-cheri
branch
from
c042509 to
da88d16
Compare
kwitaszczyk
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaring them and using them in _PROT_ALL mean mmap would fail in rtld and risked in correct autoconf style checks for PROT_CAP on systems that otherwise don't support it.
This will conflict with @qwattash's proposed change to make vm_prot2vmprot MD, but it's easy to resolve.