cheribsd-release: include all built kernels #334
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already do this as part of installing the cheribsd-$ARCH targets, in BuildFreeBSD::_installkernel (called by BuildFreeBSD::install from BuildFreeBSD::process via delegation to its superclass Project::process), but BuildFreeBSDReleaseMixin overrides its process() method and does not delegate to this existing installation machinery. Note that CheriBSD itself sets this NO_INSTALLEXTRAKERNELS control to "no" on aarch64c if it isn't already set, presumably so that self-hosted Morello builds do the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this as part of installing the cheribsd-$ARCH targets, in BuildFreeBSD::_installkernel (called by BuildFreeBSD::install from BuildFreeBSD::process via delegation to its superclass Project::process), but BuildFreeBSDReleaseMixin overrides its process() method and does not delegate to this existing installation machinery.
Note that CheriBSD itself sets this NO_INSTALLEXTRAKERNELS control to "no" on aarch64c if it isn't already set, presumably so that self-hosted Morello builds do the right thing.