Skip to content

disk-image-minimal: use a glob for run-many #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Conversation

brooksdavis
Copy link
Member

Add any files in usr/share/examples/cheribsdtest to that builds without purecap successfully add all zero of them rather than failing to add usr/share/examples/cheribsdtest/run-many.

This is breaking CI for CheriBSD.

Add any files in usr/share/examples/cheribsdtest to that builds without
purecap successfully add all zero of them rather than failing to add
usr/share/examples/cheribsdtest/run-many.
Copy link
Member

@jrtc27 jrtc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the breakage, should have thought to test a non-CHERI build, not the kind of thing the test suite can catch. A bit frustrating that pre-commit checks didn’t pick up the typing oversight though, unless I hadn’t quite installed them properly.

@brooksdavis brooksdavis merged commit f755db0 into main Jul 1, 2025
9 checks passed
@brooksdavis brooksdavis deleted the optional-run-many branch July 1, 2025 17:20
@arichardson
Copy link
Member

Sorry for the breakage, should have thought to test a non-CHERI build, not the kind of thing the test suite can catch. A bit frustrating that pre-commit checks didn’t pick up the typing oversight though, unless I hadn’t quite installed them properly.

The type checker is too slow for pre commit checks so it only runs once pushed. It also seems to be mostly unmaintained now... I saw there is a newer one that is written in rust and supposedly much faster but it's a lot stricter so will need some fixes before migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants