Read target-abi from the first bitcode file for LTO #543
+68
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current tests don't actually include the function in the output file. I found this while trying to debug a LTO crash for CHERI-RISC-V that wasn't reproducible with these tests until I changed them to actually emit the function code. We could also override the entry symbol, but changing the LLVM IR function name to _start seemed simpler.
This is done in a rather ugly way inside createTargetMachine(): when the Config object is created, we haven't read the first llvm::Module yet so we create a copy of the TargetOptions and update the ABIName there.
In the case of LTO invoked directly via LLD we might not have a valid features string, so fall back to reading the ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly a clean approach but seems to work.