-
Notifications
You must be signed in to change notification settings - Fork 58
Add a CI job to build a docker image with the compiler installed #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
This takes a bit over an hour to run with the targets limited to RISC-V+Host and it doesn't run the tests yet. This should allow reusing the compiler in other GitHub actions.
167564d to
3db0bdc
Compare
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: [ "main", "dev", "github-action-docker-image" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will drop the second commit adding this branch before merging.
|
Hmm now it's failing with |
|
Looks like this succeeded in 2 hours - I wonder if we should add running the tests? |
How long does it take? Presumably the reason to do it is, although Jenkins will run the tests, that won't stop the GitHub Actions job from publishing the image if they're failing? (Ignoring the rare "Jenkins passes but GitHub fails" case) |
I've added the tests now. I think not publishing the image on failing tests is important so even if it takes 4 hours that's worthwhile. How do you feel about building+testing all targets vs just |
Test Results91 734 tests 88 548 ✅ 2h 34m 26s ⏱️ Results for commit 641dbf6. |
This takes a bit over an hour to run with the targets limited to RISC-V+Host and it doesn't run the tests yet.
This should allow reusing the compiler in other GitHub actions.
Example run: https://github.com/arichardson/llvm-project/actions/runs/19867025000/job/56932513168 and the image from that can be fetched as
ghcr.io/arichardson/llvm-project:github-actions-test