-
Notifications
You must be signed in to change notification settings - Fork 0
refresh all code and docs #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also note that the "check broken" workflow is failing, and this is to be expected because of my fake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all great changes; I like how you've rewritten the docs for a lay audience, and the changes to what the checker scripts report are way more readable and actionable. Nice work!
Regarding the link-checker workflow failing by default due to the dummy links, while it's unusual to ship failing tests I think, like you said, it's good motivation for them to replace the links with real ones.
|
Fixed some last minute typos and forgot to force-enable colors on github actions: |
|
thanks! |
Related: CU-DBMI/redirects-website#2
This PR is in response to a user encountering workflow failures and not understanding why, because they had neglected to include a
tofield in a few of their entries. Currently, the logging prints the "entry number" (the index in the array/list), but that's not super helpful when looking at raw yaml because each entry will take up at least two lines (can have empty lines between entries, comments, etc). Printing a line number would be most helpful, but is not very simple in the yaml parsing library I'm using, or in any other library I saw. So instead I'm printing just the stringified entry, or another field value when appropriate. This should help prevent user errors in the future. Now it will look like:Instead of:
chalkfor the scripts, and upgrade to latest versions of packages