Fix fire hull climate scalar mapping to respect hull time layers#209
Merged
Fix fire hull climate scalar mapping to respect hull time layers#209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
hull.t_days_vert, computingn_layers, and ensuringn_vertices % n_layers == 0before expanding scalars to vertices.hull.event.t0 + pd.to_timedelta(...)andreindexthesummary.per_day_meanonto those layer dates, usingffill().bfill()when necessary, then expandday_valswithnp.repeat(..., verts_per_layer)to produce per-vertexintensities.ValueErrorif expanded scalar length does not match vertex count.scalar_debug_mode="slice"(colors by slice index) alongside the existingscalar_debug_mode="z", and enriched thefire_hull_scalar_debugprintout to includescalar_dtype,unique_count,n_layers, andverts_per_layerfor better pre-render inspection.zdiagnostics (tests/test_fire_hull_viewer_scalars.py).Testing
pytest tests/test_fire_hull_viewer_scalars.py -qand observed all tests passing (4 passed, 1 warning).pytest tests/test_fire_plot_cube_first.py tests/test_fire_plot_loader_calls.py -qto validate integration with thefire_plotpaths and observed all tests passing (11 passed, 1 warning).Codex Task