Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
xarrayfrom being imported at package import time to reduce import-time failures and overhead.Description
xarrayeagerly incubedynamics.__init__by guarding the import withtyping.TYPE_CHECKINGand remove top-level viz imports; add lazy wrappersshow_cube_lexcubeandplot_median_over_spacethat import the real viz functions on call.cubedynamics.verbs, remove top-levelcubedynamics.vizandxarrayimports and introduce a helper_import_xarray()for lazyxarrayloading, and importcubedynamics.vizinside theshow_cube_lexcubeverb implementation._unwrap_dataarraysignature to avoid referencingxrat import time and use_import_xarray()where runtime access toxarrayis required.tests/test_verbs_import_no_eager_viz.pythat verifies importingcubedynamics.verbsdoes not eagerly loadcubedynamics.vizorcubedynamics.viz.lexcube_viz.Testing
tests/test_verbs_import_no_eager_viz.py, which asserts that importingcubedynamics.verbsdoes not placecubedynamics.vizorcubedynamics.viz.lexcube_vizintosys.modules, and the test passed.Codex Task