Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v.plot()custom cube viewer vsv.fire_plot()Plotly hull) which caused confusion and fragile future changes.Description
AGENTS.mdtitled Visualization architecture and fire plot recovery plan that documents the transition state, separation-of-concerns, and agent implementation rules. (AGENTS.md)docs/recipes/fire_event_vase_hull.mdwith a new Current viewer status section that verbatim-states thatv.fire_plot()returns a fire-event bundle plus a Plotly hull figure and is not yet rendered through the customv.plot()backend. (docs/recipes/fire_event_vase_hull.md)v.plot()is the canonical custom viewer and specialized workflows may temporarily use separate backends. (docs/viz/cube_viewer.md)docs/dev/fire_plot_architecture.mddescribing current layering, stable separations, migration strategy, anti-patterns, and recommended next incremental PRs. (docs/dev/fire_plot_architecture.md)fire_plotdocstring insrc/cubedynamics/verbs/fire.pyand updatedocs/api/verbs.mdto reflect thatfire_plot(...)returns a Plotlyfig_hulltoday. (src/cubedynamics/verbs/fire.py,docs/api/verbs.md)mkdocs.yml)Testing
pytest tests/test_fire_plot_loader_calls.py tests/test_fire_plot_cube_first.py tests/test_plot_verb.py -q; the suite passed (15 passed).mkdocs build --strict; the build completed successfully (warnings about nav coverage and an upstream MkDocs warning were emitted but did not fail the build).Codex Task