Fixes issue where KSP_VERION_MIN/MAX were being ignored when checking… #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for an update available
Add code to ensure that the Min/max are both there, and that they override the KSPVersion if it is there Added Min/Max functions to VersionIfno Added FixMissingMinMax after parsing files if KSP_VERSION is outside the bounds of KSP_VERSION_MIN and KSP_VERSION_MAX, it will be replaced with the appropriate one. If only one of the KSP_VERSION_MIN and KSP_VERSION_MAX are specified and KSP_VERSION is specified, then the missing parameter will be set to either the appropriate min/max against KSP_VERSION Added some messages to indicate what sort of error occurred Updated the "built for" message to be either a single version or a range of versions
Fixed bug where a missing VERSION would cause the dropdown to cause nullrefs Removed Min/Max functions to VersionInfno as not needed anymore Removed FixMissingMinMax after parsing files as not needed anymore
Added and improved error messages in log Added code updates to MiniAVC Deleted dlls
Added jenkins config for MiniAVC
Updated changelog
Remove extra curly brace in version file
Handle duplicative dll paths
The inner foreach is missing a close parenthesis
Fix syntax error
Duplicate elimiation
Fixed textures path
Create a schema for .version files
Update HttpWebRequest Timeout to be 10 seconds, not 10 milliseconds
…changelogs Disabled all old Kerbalstuff code
Report which configPath was not found
Add null check in MiniAVC for kspExcludeVersions
Add null check in MiniAVC for kspExcludeVersions Report which configPath was not found Removed threading from full AVC, was not working properly with HTTPWebRequest Added checks for null or empty changelog to avoid exception with empty changelog Cleaned up error logging, no need to exception for a web error Moved log into Logs directory for full KSP-AVC Removed all threading from MiniAVC Converted UnityWebRequest to HTTPWebRequest in MiniAVC
Updated version file for 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19, probably #9 and #10 as well