Implements Command Line Matching #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications can't be matched using wm_class or window title, especially when installed via Snap. For example, the Snap-packaged version of Firefox (the default install for Ubuntu) often ignores wm_class and sets inconsistent window titles. This commit introduces a new mode, "match-cmdline", which enables matching windows based on the full launch command, including arguments. This adds a useful general-purpose capability and, in particular, allows users to assign separate shortcuts to different Firefox profiles under Ubuntu and apply run-or-raise behavior to each.
Stops tracking schemas.compiled
Member
|
Very clever, seems great to me! I'll try to check thoroughly soon |
e3rd
requested changes
Sep 1, 2025
Member
e3rd
left a comment
e3rd
left a comment
There was a problem hiding this comment.
I like it, thanks! To be aligned with the code style, could you remove semicolons and use {} around return statements too?
| import Gio from 'gi://Gio' | ||
| import GLib from 'gi://GLib' | ||
| import Mtk from 'gi://Mtk' | ||
| import * as Main from 'resource:///org/gnome/shell/ui/main.js' |
Member
There was a problem hiding this comment.
It seems the Main is not used in your code, what's the purpose here?
| @@ -1 +1,3 @@ | |||
| build | |||
| notes | |||
Member
There was a problem hiding this comment.
What creates the notes file? I tend to have the code short, if it is unlikely the notes will be created on other machines, I prefer to put such things info .git/info/exclude instead
| if (!ok) return ""; | ||
|
|
||
| try { | ||
| const file = Gio.File.new_for_path(`/proc/${pid}/cmdline`); |
Member
There was a problem hiding this comment.
These two lines (which might be perfomance-inefficient) are run twice. Is it on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications can't be matched using wm_class or window title, especially when installed via Snap. For example, the Snap-packaged version of Firefox (the default install for Ubuntu) ignores wm_class and rewrites window titles.
This commit introduces a new mode, "match-cmdline", which enables matching windows based on the full launch command, including arguments. This adds a useful general-purpose capability and, in particular, allows users to assign separate shortcuts to different Firefox profiles under Ubuntu and apply run-or-raise behavior to each.