Only default to attaching debugger if aspire itself is under debug #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #31
This allows for the common case that when running under debug, things should debug. However, if things are not under debug, probably don't need to attach the debugger.
PR Classification
Code cleanup and configuration updates.
PR Summary
This pull request includes code cleanup by commenting out debugger hook functionality and updates to configuration handling in tests. Key changes include:
WebObjectActivator.cs: Modified type cast forIKeyedServiceProvider.IISExpressEntensions.cs: Commented out debugger hook code in two locations.DebugResourceExtensions.cs: EnhancedIsDebugModemethod with new conditions.OutputWatcherIntegrationTests.cs: Addedusingdirectives and introduced a new timeout constant.OutputWatcherIntegrationTests.cs: Updated HTTP client configuration to use dynamic timeout values.