Skip to content

Update Microsoft.CodeDom.Providers.DotNetCompilerPlatform - closes #59 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CZEMacLeod wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Microsoft.CodeDom.Providers.DotNetCompilerPlatform - closes #59 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4757744
Select MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version based …
CZEMacLeod Apr 12, 2023
997b15f
Update docs to show common package versions now depend on target fram…
CZEMacLeod May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions docs/RazorLibrary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,12 @@ For more information see

### Common Packages

| Package | Default Version | Property |
| ------- | --------------- | -------- |
| `Microsoft.Net.Compilers.Toolset` | 4.5.0 | `MicrosoftNetCompilersToolset_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | 3.6.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
| Package | Target Framework | Default Version | Property |
| ------- | ---------------- | --------------- | -------- |
| `Microsoft.Net.Compilers.Toolset` | Any | 4.5.0 | `MicrosoftNetCompilersToolset_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | <4.6.2 | 3.6.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | >=4.6.2 and < 4.7.2 | 3.11.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | >=4.7.2 | 4.1.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |

### Specific Packages

Expand Down
13 changes: 8 additions & 5 deletions docs/SDK.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ You can also use the [templates](Templates.md) to easily create new projects.
| -------- | ------------- | ----------- |
| `ExcludeSDKDefaultPackages` | false | Do not include the default packages `Microsoft.Net.Compilers.Toolset` and `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` |
| `ApplySDKDefaultPackageVersions` | true* | Apply default version numbers to packages unless using a Central Package Management system |
| `GeneratedBindingRedirectsAction` | None | Set the desired default behavior of what to do with SuggestedBindingRedirects if not yet set.<br>See [automatically generated binding redirects](Binding_Redirects/Autogenerating-Binding-Redirects.md)<br><ul><li>`None` - Do nothing except show the warning</li><li>`Preview` - Creates new Web.BindingRedirects.config file showing proposed changes</li><li>`Overwrite` - Updates the $(AppConfig) aka web.config in the project root</li></ul> |
| `GeneratedBindingRedirectsAction` | None | Set the desired default behavior of what to do with SuggestedBindingRedirects if not yet set.<br>See [automatically generated binding redirects](Binding_Redirects/Autogenerating-Binding-Redirects.md)<br><ul><li>`None` - Do nothing except show the warning</li><li>`Preview` - Creates new Web.BindingRedirects.config file showing proposed changes</li><li>`Overwrite` - Updates the $(AppConfig) aka web.config in the project root and any `RazorAppConfigFiles` files</li></ul> |

*Version numbers are not applied if you are using `Microsoft.Build.CentralPackageVersions` version 2.1.1 or higher. Remember to include the packages in your central package versions file.

Expand All @@ -52,6 +52,7 @@ You can also use the [templates](Templates.md) to easily create new projects.
** You will have to adjust your web.config to change the `system.codedom/compilers/compiler` `compilerOptions` attribute to set the langversion - it won't automatically use the `LangVersion` property from your project file.

### Deprecated Properties

| Property | Default value | Description |
| -------- | ------------- | ----------- |
| `ExcludeASPNetCompilers` | false | Use `ExcludeSDKDefaultPackages` instead |
Expand All @@ -61,7 +62,9 @@ You can also use the [templates](Templates.md) to easily create new projects.

### Common Packages

| Package | Default Version | Property |
| ------- | --------------- | -------- |
| `Microsoft.Net.Compilers.Toolset` | 4.5.0 | `MicrosoftNetCompilersToolset_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | 3.6.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
| Package | Target Framework | Default Version | Property |
| ------- | ---------------- | --------------- | -------- |
| `Microsoft.Net.Compilers.Toolset` | Any | 4.5.0 | `MicrosoftNetCompilersToolset_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | <4.6.2 | 3.6.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | >=4.6.2 and < 4.7.2 | 3.11.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
| `Microsoft.CodeDom.Providers.DotNetCompilerPlatform` | >=4.7.2 | 4.1.0 | `MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version` |
6 changes: 5 additions & 1 deletion src/MSBuild.SDK.SystemWeb.CommonFiles/Sdk/MSBuild.SDK.SystemWeb.Common.DefaultPackages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup Condition="'$(ExcludeSDKDefaultPackages)'=='false'">
<MicrosoftNetCompilersToolset_Version Condition="'$(MicrosoftNetCompilersToolset_Version)'==''">4.5.0</MicrosoftNetCompilersToolset_Version>
<MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version Condition="'$(MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version)'==''">3.6.0</MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version>
</PropertyGroup>
<PropertyGroup Condition="'$(MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version)'==''">
<MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version>3.6.0</MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version><!-- net 4.5 / 4.6 / 4.7.2+ -->
<MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version Condition="$([System.Version]::Parse('$(TargetFrameworkVersion.Substring(1))').CompareTo($([System.Version]::Parse('4.6.2')))) &gt;= 0">3.11.0</MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version><!-- net 4.6.2, 4.7.2+ -->
<MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version Condition="$([System.Version]::Parse('$(TargetFrameworkVersion.Substring(1))').CompareTo($([System.Version]::Parse('4.7.2')))) &gt;= 0">4.1.0</MicrosoftCodeDomProvidersDotNetCompilerPlatform_Version><!-- net 4.7.2+ -->
</PropertyGroup>
</Project>