Skip to content

Remove lodash.isobjectlike package #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Remove lodash.isobjectlike package #377

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dc1022
Remove lodash.isobjectlike package
trkic-zeiss Oct 10, 2024
36987ef
Removed Lodash from almanac.js
chris-pardy Oct 11, 2024
c39b45a
Remove Lodash from rule result
chris-pardy Oct 11, 2024
ed0429c
Commit @jagernet-ops suggestion to use use the instanceof operator
trkic-zeiss Oct 14, 2024
6ede34e
Based on @chris-pardy suggestion using typeof because its more perfor…
trkic-zeiss Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
"clone": "^2.1.2",
"eventemitter2": "^6.4.4",
"hash-it": "^6.0.0",
"jsonpath-plus": "^7.2.0",
"lodash.isobjectlike": "^4.0.0"
"jsonpath-plus": "^7.2.0"
}
}
5 changes: 2 additions & 3 deletions src/almanac.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { UndefinedFactError } from './errors'
import debug from './debug'

import { JSONPath } from 'jsonpath-plus'
import isObjectLike from 'lodash.isobjectlike'

function defaultPathResolver (value, path) {
return JSONPath({ path, json: value, wrap: false })
Expand Down Expand Up @@ -161,7 +160,7 @@ export default class Almanac {
debug(`condition::evaluate extracting object property ${path}`)
return factValuePromise
.then(factValue => {
if (isObjectLike(factValue)) {
if (factValue != null && typeof factValue === 'object') {
const pathValue = this.pathResolver(factValue, path)
debug(`condition::evaluate extracting object property ${path}, received: ${JSON.stringify(pathValue)}`)
return pathValue
Expand All @@ -179,7 +178,7 @@ export default class Almanac {
* Interprets value as either a primitive, or if a fact, retrieves the fact value
*/
getValue (value) {
if (isObjectLike(value) && Object.prototype.hasOwnProperty.call(value, 'fact')) { // value = { fact: 'xyz' }
if (Boolean(value instanceof Object) && Object.prototype.hasOwnProperty.call(value, 'fact')) { // value = { fact: 'xyz' }
return this.factValue(value.fact, value.params, value.path)
}
return Promise.resolve(value)
Expand Down
3 changes: 1 addition & 2 deletions src/rule-result.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict'

import deepClone from 'clone'
import isObject from 'lodash.isobjectlike'

export default class RuleResult {
constructor (conditions, event, priority, name) {
Expand All @@ -17,7 +16,7 @@ export default class RuleResult {
}

resolveEventParams (almanac) {
if (isObject(this.event.params)) {
if (this.event.params instanceof Object) {
const updates = []
for (const key in this.event.params) {
if (Object.prototype.hasOwnProperty.call(this.event.params, key)) {
Expand Down