Bug fixes #378
Merged
Bug fixes #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
CacheControl
approved these changes
Oct 12, 2024
Significantly simplify the method by leveraging the short-circuiting of the || and && operators. Replaces CacheControl#368 Co-Author Mahi <[email protected]>
Change the call signature, leverage built-in formatting on console. Move debug enablement checks to file load. Replaces CacheControl#363 Resolves CacheControl#362 Co-Author Nirmal Patel <[email protected]>
chris-pardy
force-pushed
the
bug-fixes
branch
from
b9e30d1 to
86d210d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #368 and #363 Fixes #362
For prioritize and run the method can be significantly paired down as there's currently a lot of code that isn't actually doing anything. This doesn't move it to use the
reducefunction on arrays (see comment on IE 8 compatibility). I'd like to punt on that change for a tools modernization and type-script port.For the JSON Stringifying, changing the call to
debugto have a number of improvements. Firstly what is exported is either a no-op function or just a bound console.debug method. This avoids repeating the environment variable or localstorage checks on every call to the function. In particular local storage being a synchronous API to access a persisted store that is also global to the browser makes it much slower. This has the downside that you'll need to reload the page / restart node when enabling debug.Additionally the debug messages no longer in-line values and instead present them as an object collection in the second argument. This allows the built-in debug formatter to handle them which correctly formats BigInts and other complex objects.