Explicitly depend on kdialog for cachyos-calamares-qt6-next-limine#1021
Closed
5long wants to merge 1 commit intoCachyOS:masterfrom
Closed
Explicitly depend on kdialog for cachyos-calamares-qt6-next-limine#10215long wants to merge 1 commit intoCachyOS:masterfrom
5long wants to merge 1 commit intoCachyOS:masterfrom
Conversation
Author
|
With #73 closed this patch is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming we're moving forward with CachyOS/CachyOS-Live-ISO#73, new Live ISO will replace yad with kdialog. Also quoting @ventureoo :
This will make new calamares depend on kdialog as well. I think I need to come up with a plan to make sure users' old ISOs won't break.
Given that the initial install script upgrades calamares after picking a bootloader, new calamares will be running on old ISO (e.g.
251129) where there is no kdialog. This PR fixes this situation by installing kdialog as a dependency of calamares.Occasionally, testing ISO is being downloaded in Discord for early testing. Old calamares packages will break on them for the lack of yad.
This can be mitigated by merging this PR & building new calamares packages before CachyOS/CachyOS-Live-ISO#73 gets merged, preventing this situation completely.
Ideally there should be a time window of at least 1 day to wait for all the mirrors to catch up syncing.