Skip to content

fix: backport spikekill, aggregate, and realtime graph fixes to 1.2.x #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
somethingwithproof wants to merge 1 commit into from
Closed

fix: backport spikekill, aggregate, and realtime graph fixes to 1.2.x #6905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api_aggregate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ function aggregate_graph_templates_graph_save($local_graph_id, $graph_template_i
$graph_data['title_cache'] = $existing_data['title_cache'];
} else {
/* this is an existing graph and not templated from aggregate,
* reuse its old data */
* re-use its old data */
$graph_data = $existing_data;
}
Comment on lines 142 to 147
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions the SIMILAR vs ALL percentile replacement fix, but this file’s functional logic still treats SIMILAR like ALL in several places (e.g., conditions of the form "== AGGREGATE_TOTAL_TYPE_ALL || == AGGREGATE_TOTAL_TYPE_SIMILAR"). If SIMILAR is supposed to use per-data-source (aggregate_current*) functions, those conditions need to be split into distinct branches so SIMILAR does not map to aggregate_sum/aggregate_sum_peak.

Copilot uses AI. Check for mistakes.

Expand Down
Loading