-
Notifications
You must be signed in to change notification settings - Fork 18
fix(ui): correctly match negation in app report #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses error handling in JavaScript interop calls and fixes negation logic in database tenant visibility functions. The changes improve robustness by preventing JavaScript exceptions from crashing the UI and correct the logic for matching negated rules in app reports.
- Adds try/catch blocks around JavaScript interop calls to handle JSException gracefully
- Fixes negation matching logic in SQL functions by removing incorrect rule-level negation checks
- Simplifies database queries by removing unnecessary JOIN operations with the rule table
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AnchorNavToRSB.razor | Adds exception handling around JavaScript interop calls to prevent crashes |
| fworch-api-funcs.sql | Fixes negation logic and removes unnecessary JOINs in tenant visibility functions |
tpurschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
rules report still working correctly
-
AppRule report still shows rules with negated parts incorrectly:
eg. a rule containing "not rfc1918_netze" (containing 10.0.0.0/8) in destination is shown for an application that only has addresses starting with 10.x
|
|
@dependabot recreate |




fixes #3349