-
Notifications
You must be signed in to change notification settings - Fork 18
feat-ISSUE-3782-PR 1/2 adding crosstables rule - zone for destination and source #3834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: importer-rework
Are you sure you want to change the base?
feat-ISSUE-3782-PR 1/2 adding crosstables rule - zone for destination and source #3834
Conversation
|
@Imat00 sorry I also had to add some permissions - could you please resolve the resulting conflicts in your branch? |
should be done |
|
@Imat00 there seems to be an issue with the metadata file (test import job fails) |
Yes, currently working on it |
|
Finally! |
Kept incoming changes from remote and renamed local methods for clarity: - DisplayDestinationZones() (was DisplayDestinationZone() before) - DisplaySourceZones() (was DisplaySourceZone() before)
fixed: warnings
…e zones - changed GraphQL fragments for rule zones - renamed normalized rule fields from *zone to *zones - updated export tests for rules with multiple zones
… via upgrade script
…eat/multiple-rule-zones
|
I added the necessary changes in the importer and middleware to correctly handle multiple zones per rule source/destination. And I renamed the new tables to make it more consistent with existing similar tables. One note / inconsistency regarding the new tables: We now have a situation where we link to the crosstable rule_from_zone, like with rule_from via ids, but we do not write the zones directly into the rule as a string, like we do with rule_src. (same with rule_to_zone). This has the benefit, that we do not get a new rule version whenever the zones change. only the crosstable changes. But it would be more consistent if we also wrote the zones as string to each rule entry (or the other way around, remove the rule_src/dst/svc etc fields from the rule) |
todo drop columns rule_from/to_zone in rule
|



management - role reporter - select - add mgm_uid
rule - recertifier - select - add is_global and rulebase_id
rule - modeller - select - add is_global and rulebase_id
rule_from/rule_to - middleware - seelct - add cl_from_relevant_for_tenant
rule_service and more add removed in select for filtered roles
changelog_rule add cl_rule_relevant_for_tenant in select for filtered roles