migrate test framework #3919
Open
migrate test framework #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unified Test Role There is now a single tests role that conditionally runs unit and/or integration suites via the new driver in roles/tests/tasks/main.yml (lines 1-15), controlled by the defaults in roles/tests/defaults/main.yml (lines 1-2). Toggle either set with e.g. ansible-playbook site.yml -e run_unit_tests=false or … -e run_integration_tests=false. All former unit automation (C# sync/run plus importer Python tests) now lives in roles/tests/tasks/unit.yml (lines 1-45), while the full integration pipeline (sample data prep, API/import/web checks, cleanup) sits in roles/tests/tasks/integration.yml (lines 2-88) with its existing handler logic preserved in roles/tests/handlers/main.yml. Unit and integration assets were consolidated under roles/tests/files/**, so the Visual Studio solution and VS Code workspace both point at the new location (roles/FWO.sln (line 10), fwo.code-workspace (lines 5-9)), eliminating references to the deleted tests-unit/tests-integration roles. The playbook now executes the combined role once (site.yml (lines 94-110)), so tagging --tags unittests or --tags integrationtests still works while sharing the same installer hooks. Usage / Next Steps Run ansible-playbook site.yml --tags test for the full suite, or add -e run_integration_tests=false / -e run_unit_tests=false to limit scope. If you rely on IDE links, reopen the workspace/solution so the new roles/tests/... paths are loaded. (Optional) Execute the playbook once to ensure both suites still pass in this branch; I haven’t run them here.
Contributor
Author
|
@Robin-Smets this is what codex suggests for migrating the test roles |
Contributor
Author
|
have not tested any of this yet |
Contributor
|
Ok, thank you, I will have a look into this.
|
…firewall-orchestrator into feat/test-migration-installer
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified Test Role
There is now a single tests role that conditionally runs unit and/or integration suites via the new driver in roles/tests/tasks/main.yml (lines 1-15), controlled by the defaults in roles/tests/defaults/main.yml (lines 1-2). Toggle either set with e.g. ansible-playbook site.yml -e run_unit_tests=false or … -e run_integration_tests=false. All former unit automation (C# sync/run plus importer Python tests) now lives in roles/tests/tasks/unit.yml (lines 1-45), while the full integration pipeline (sample data prep, API/import/web checks, cleanup) sits in roles/tests/tasks/integration.yml (lines 2-88) with its existing handler logic preserved in roles/tests/handlers/main.yml. Unit and integration assets were consolidated under roles/tests/files/**, so the Visual Studio solution and VS Code workspace both point at the new location (roles/FWO.sln (line 10), fwo.code-workspace (lines 5-9)), eliminating references to the deleted tests-unit/tests-integration roles. The playbook now executes the combined role once (site.yml (lines 94-110)), so tagging --tags unittests or --tags integrationtests still works while sharing the same installer hooks. Usage / Next Steps
Run ansible-playbook site.yml --tags test for the full suite, or add -e run_integration_tests=false / -e run_unit_tests=false to limit scope. If you rely on IDE links, reopen the workspace/solution so the new roles/tests/... paths are loaded. (Optional) Execute the playbook once to ensure both suites still pass in this branch; I haven’t run them here.