Skip to content

Conversation

@shimwell
Copy link
Collaborator

@shimwell shimwell commented Apr 4, 2025

In the readme examples I think loc and color are not used

perhaps best to remove these two to make the example quicker for people to understand

I also corrected the import package name as it had the old package name and I removed an argument that otherwise raises an error in the gmsh.write function

@jmwright
Copy link
Member

jmwright commented Apr 7, 2025

@shimwell Thanks. Is this finished and ready for review?

@shimwell
Copy link
Collaborator Author

shimwell commented Apr 7, 2025

Thanks yes this is ready for review

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimwell !

@jmwright jmwright merged commit 7f1036a into CadQuery:main Apr 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants