Skip to content

Conversation

@shimwell
Copy link
Collaborator

@shimwell shimwell commented Apr 8, 2025

This PR fixes issue #14 by adding a file import to the init

examples and tests have been updated to use

import assembly_mesh_plugin

instead of

import assembly_mesh_plugin.plugin

@shimwell shimwell linked an issue Apr 8, 2025 that may be closed by this pull request
@shimwell
Copy link
Collaborator Author

shimwell commented Apr 8, 2025

now passing lint tests, this one is ready for review

@jmwright
Copy link
Member

jmwright commented Apr 8, 2025

@shimwell Do you have a feel for how many scripts are using this plugin now that will be broken by this import change? It's not hard to fix, but it's always a shock when you upgrade or reinstall a plugin and its behavior has changed like this.

@shimwell
Copy link
Collaborator Author

shimwell commented Apr 8, 2025

I've only seen my own scripts which I've fixed in fusion-energy/cad_to_dagmc#128

Not seen any other use. There might be some but I've not seen it.

Perhaps we use the rust style versioning to indicate breaking API changes and release v0.2.0 after this PR

Also I'm not sure if it actually does break the current way of using it.

@jmwright jmwright merged commit 1f82726 into CadQuery:main Apr 8, 2025
3 checks passed
@jmwright
Copy link
Member

jmwright commented Apr 8, 2025

Thanks @shimwell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slightly shorter import

2 participants