You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Probably too late now, but might be worth breaking API compatibility to fix it. The lorenz-dsl-groovy module provides the org.cadixdev.lorenz.dsl package and this PR provides the org.cadixdev.lorenz.dsl.kotlin package. In order for these libraries to be compatible with JPMS modules can't provide the same package, so that's okay, but it would be nice if the lorenz-dsl-groovy module provided the org.cadixdev.lorenz.dsl.groovy package instead for consistency - and that would open the option for something like a lorenz-dsl project which could do something similar but with lambda expressions and provide near-DSL like support for Java.
Alright, I've relocated the Groovy DSL. Hopefully I'll find some time over the next week or so to finish this off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24
Huge thanks to @pie-flavor for helping me to navigate my way through Kotlin 👍
todo