fix: correct permission query condition in Dashboard#1
Open
CaioMatins wants to merge 1 commit intodevelopfrom
Open
fix: correct permission query condition in Dashboard#1CaioMatins wants to merge 1 commit intodevelopfrom
CaioMatins wants to merge 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the
get_permission_query_conditionsfunction of Dashboard doctype where the SQL condition was missing parentheses. This could lead to incorrect logical evaluation when the query is combined with other conditions.Problem
The current implementation returns an SQL condition without parentheses:
return f"
tabDashboard.modulein ({','.join(allowed_modules)}) or {module_not_set} "Solution
return f" (
tabDashboard.modulein ({','.join(allowed_modules)}) or {module_not_set}) "Impact
Example Scenario
Imagine a user has access to Module1 and Module2. Without parentheses, a query like:
tabDashboard.moduleIN ('Module1', 'Module2') OR ifnull(tabDashboard.module, '') = '' ANDtabDashboard.is_active= 1Would be evaluated as:
(
tabDashboard.moduleIN ('Module1', 'Module2') OR ifnull(tabDashboard.module, '') = '') ANDtabDashboard.is_active= 1With the fix, the logical grouping is preserved, and the query works as intended.
Checklist
Additional Notes