Skip to content

Fixed unit test failures #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshblank73 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed unit test failures #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99fee6b
Include extra message in output
joshblank73 May 13, 2024
d3bd02d
Merge pull request #1 from joshblank73/fix-candygrams
joshblank73 May 13, 2024
88d989f
Fixed unit test failures
joshblank73 May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions R/compliments.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#' @return A compliment string
#'
#' @export
really_pretty <- function(name, follow_up = TRUE) {
really_pretty <- function(name, follow_up = FALSE) {

compliment <- glue::glue("You're, like, really pretty, {name}.")
compliment <- glue::glue("You're, like, really pretty {name}.")

if (follow_up) {
compliment <- paste(compliment,
Expand Down Expand Up @@ -41,5 +41,3 @@ nice_style <- function(object, adjective = "vintage", follow_up = FALSE) {
return(compliment)

}


4 changes: 2 additions & 2 deletions R/give_candygrams.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#'
#' @return A candy gram announcement
#'
#' @importFrom stringr str_detect str_to_title
#' @importFrom stringr str_detect str_to_title str_trim
#' @importFrom english as.english
#'
#' @export
Expand All @@ -30,7 +30,7 @@ give_candygrams <- function(person, number,
number <- str_to_title(as.english(number))


glue::glue("{number} for {person}.")
stringr::str_trim(glue::glue("{number} for {person}. {extra_message}"))



Expand Down
7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# meangirls

<!-- badges: start -->

<!-- badges: end -->

The goal of meangirls is to create quotes in the style of the 2004
Expand Down Expand Up @@ -92,18 +91,18 @@ You can also give extra commentary to your announcement:
``` r
give_candygrams("Taylor Zimmerman", 2,
extra_message = "Merry Christmas!")
#> Two for Taylor Zimmerman.
#> Two for Taylor Zimmerman. Merry Christmas!
```

Some special cases trigger automatic extra commentary or special
behavior:

``` r
give_candygrams("Glen Coco", 4)
#> Four for Glen Coco.
#> Four for Glen Coco. You go, Glen Coco!
```

``` r
give_candygrams("Gretchen Weiners", 4)
#> [1] "None for Grethen Weiners."
#> None for Gretchen Weiners.
```