Skip to content

Fix compliments to pass unit test #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jack23brown wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix compliments to pass unit test #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba385a5
fixed extra message output
May 13, 2024
0654a06
small spacing fix in extra message
May 13, 2024
4adccd3
fixed compliments unit test
May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/compliments.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#' @return A compliment string
#'
#' @export
really_pretty <- function(name, follow_up = TRUE) {
really_pretty <- function(name, follow_up = FALSE) {

compliment <- glue::glue("You're, like, really pretty, {name}.")
compliment <- glue::glue("You're, like, really pretty {name}.")

if (follow_up) {
compliment <- paste(compliment,
Expand Down
2 changes: 1 addition & 1 deletion R/give_candygrams.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ give_candygrams <- function(person, number,
number <- str_to_title(as.english(number))


glue::glue("{number} for {person}.")
glue::glue("{number} for {person}.{extra_message}")



Expand Down
17 changes: 4 additions & 13 deletions README.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ knitr::opts_chunk$set(
# meangirls

<!-- badges: start -->

<!-- badges: end -->

The goal of meangirls is to create quotes in the style of the
2004 instant classic movie, *Mean Girls*.
The goal of meangirls is to create quotes in the style of the 2004 instant classic movie, *Mean Girls*.

## Installation

Expand All @@ -34,7 +34,6 @@ devtools::install_github("Cal-Poly-Advanced-R/meangirls")
library(meangirls)
```


## insults

You can use the function `boo()` to deliver a generic insult:
Expand All @@ -49,10 +48,9 @@ You can use the function `fetch()` to insult someone's made-up slang word.
fetch("Gretchen", "fetch")
```


## compliments

You can use the function `nice_style()` to compliment someone's fashion choices.
You can use the function `nice_style()` to compliment someone's fashion choices.\
The default adjective is "vintage", but you can supply your own.

```{r}
Expand All @@ -61,7 +59,6 @@ nice_style("bracelet")
nice_style("bracelet", adjective = "colorful")
```


You can use the function `really_pretty()` to tell someone they are pretty.

```{r}
Expand All @@ -77,11 +74,9 @@ really_pretty("Cady", follow_up = TRUE)
nice_style("bracelet", follow_up = TRUE)
```


## Handing out candygrams

Finally, you can use the `give_candygrams()` function to announce the number of
candygrams a person gets.
Finally, you can use the `give_candygrams()` function to announce the number of candygrams a person gets.

```{r}
give_candygrams("Taylor Zimmerman", 2)
Expand All @@ -96,16 +91,12 @@ give_candygrams("Taylor Zimmerman", 2,
extra_message = "Merry Christmas!")
```


Some special cases trigger automatic extra commentary or special behavior:


```{r}
give_candygrams("Glen Coco", 4)
```

```{r}
give_candygrams("Gretchen Weiners", 4)
```


7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# meangirls

<!-- badges: start -->

<!-- badges: end -->

The goal of meangirls is to create quotes in the style of the 2004
Expand Down Expand Up @@ -92,18 +91,18 @@ You can also give extra commentary to your announcement:
``` r
give_candygrams("Taylor Zimmerman", 2,
extra_message = "Merry Christmas!")
#> Two for Taylor Zimmerman.
#> Two for Taylor Zimmerman.Merry Christmas!
```

Some special cases trigger automatic extra commentary or special
behavior:

``` r
give_candygrams("Glen Coco", 4)
#> Four for Glen Coco.
#> Four for Glen Coco.You go, Glen Coco!
```

``` r
give_candygrams("Gretchen Weiners", 4)
#> [1] "None for Grethen Weiners."
#> None for Gretchen Weiners.
```