Skip to content

Potential fix for code scanning alert no. 87: String concatenation in loop #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vb2ae wants to merge 2 commits into
base: master
Choose a base branch
from

Improve code readability in ViewModelBinder.cs

ee1b1e5
Select commit
Loading
Failed to load commit list.
Draft

Potential fix for code scanning alert no. 87: String concatenation in loop #1003

Improve code readability in ViewModelBinder.cs
ee1b1e5
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Aug 9, 2025 in 3s

2 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 209 in src/Caliburn.Micro.Platform/ViewModelBinder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Select Note

This foreach loop immediately
maps its iteration variable to another variable
Loading
- consider mapping the sequence explicitly using '.Select(...)'.

Check warning on line 249 in src/Caliburn.Micro.Platform/ViewModelBinder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Erroneous class compare Warning

Erroneous class compare.