Skip to content

[WIP] Applying best practice #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
K4PS3 wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[WIP] Applying best practice #871

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5e9133e
Moved files in Caliburn.Micro.Core project.
K4PS3 Oct 6, 2023
e0f7276
- Extracted types from files containing more than one type.
K4PS3 Oct 7, 2023
81214f5
- Removed region from WeakValueDictionary.cs.
K4PS3 Oct 7, 2023
df3a593
- Formatted arrow expression.
K4PS3 Oct 7, 2023
35fbaac
- Applied 'Return Early Pattern' as much as possible.
K4PS3 Oct 7, 2023
ee63687
- Added disabled settings for Code Analysis.
K4PS3 Oct 7, 2023
44a7f54
- Enabled Code Analysis, 6 types of issues fixed, another 14 types st…
K4PS3 Oct 7, 2023
bd1b3a9
- Removed Zombie Code.
K4PS3 Oct 7, 2023
53b2f1d
Added the missing xml documentation because previous commits failed t…
K4PS3 Oct 7, 2023
ee08a04
- Refactored all (.csproj) to be more clean and clear.
K4PS3 Oct 9, 2023
392c420
This commit should fix most of the CodeQL errors and warning.
K4PS3 Oct 9, 2023
f7bda46
Merge branch 'Caliburn-Micro:master' into Applying-Best-Practice
K4PS3 Oct 9, 2023
0ad7002
- Fixed NameFormat issue in ViewModelLocatorTests.cs.
K4PS3 Oct 9, 2023
b4e9b39
- Fixed a bug (parent is null), I introduced when CodeQL warnings was…
K4PS3 Oct 12, 2023
05e4ab4
- Fixed another bug that I introduced when CodeQL fixed (NullReferenc…
K4PS3 Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Caliburn.Micro.Platform.Tests/ViewModelLocatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public void ConfigureTypeMappingsShouldThrowWhenDefaultSubNamespaceForViewModels
var config = new TypeMappingConfiguration {
DefaultSubNamespaceForViews = "not empty",
DefaultSubNamespaceForViewModels = string.Empty,
NameFormat = "not Empty",
NameFormat = "{0}{1}",
};

Assert.Throws<ArgumentException>(() => ViewModelLocator.ConfigureTypeMappings(config));
Expand All @@ -20,7 +20,7 @@ public void ConfigureTypeMappingsShouldThrowWhenDefaultSubNamespaceForViewModels
var config = new TypeMappingConfiguration {
DefaultSubNamespaceForViews = "not null",
DefaultSubNamespaceForViewModels = null,
NameFormat = "not null",
NameFormat = "{0}{1}",
};

Assert.Throws<ArgumentException>(() => ViewModelLocator.ConfigureTypeMappings(config));
Expand All @@ -31,7 +31,7 @@ public void ConfigureTypeMappingsShouldThrowWhenDefaultSubNamespaceForViewsIsEmp
var config = new TypeMappingConfiguration {
DefaultSubNamespaceForViews = string.Empty,
DefaultSubNamespaceForViewModels = "not Empty",
NameFormat = "not Empty",
NameFormat = "{0}{1}",
};

Assert.Throws<ArgumentException>(() => ViewModelLocator.ConfigureTypeMappings(config));
Expand All @@ -42,7 +42,7 @@ public void ConfigureTypeMappingsShouldThrowWhenDefaultSubNamespaceForViewsIsNul
var config = new TypeMappingConfiguration {
DefaultSubNamespaceForViews = null,
DefaultSubNamespaceForViewModels = "not null",
NameFormat = "not null",
NameFormat = "{0}{1}",
};

Assert.Throws<ArgumentException>(() => ViewModelLocator.ConfigureTypeMappings(config));
Expand Down