Implement support for Rust features - #22
Merged
Merged
Conversation
mrkkrp
force-pushed
the
features
branch
4 times, most recently
from
December 16, 2025 13:23
ef84d6c to
9d79497
Compare
mrkkrp
marked this pull request as ready for review
December 16, 2025 13:23
mrkkrp
force-pushed
the
features
branch
2 times, most recently
from
December 16, 2025 13:32
6c1cc3d to
45fd3f1
Compare
Contributor
Author
|
@Calsign I believe this is ready for review. The readme is probably the best starting point to get an overview of the design. |
Merged
Calsign
reviewed
Dec 21, 2025
Contributor
Author
|
I have rebased the PR, adjusted the readme as you request, and attempted to make sure that
holds even in the pure Bazel mode (no tests for this though, please take a look at the implementation). |
Calsign
reviewed
Jan 5, 2026
Calsign
left a comment
Calsign
left a comment
Owner
There was a problem hiding this comment.
This looks good.
I might like to see generation tests for the following cases:
- A negative
rust_featuredirective removing a feature from the set of default features - A nested package structure where directives are used to override behavior from a parent package
| match args { | ||
| Args::OneShot { path } => { | ||
| let mut rust_imports = parser::parse_imports(path)?; | ||
| let mut rust_imports = parser::parse_imports(path, &Vec::new())?; |
Owner
There was a problem hiding this comment.
nit: use &[] instead of &Vec::new()
Contributor
Author
Owner
|
Thanks! |
Calsign
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #21.