gazelle::provides macro/directive - #39
Merged
Merged
Conversation
Glob imports (e.g. `use some_crate::prelude::*`) can introduce arbitrary modules, and gazelle has no way of tracking this. Similarly, macros can generate modules. There are various ways one could imagine making this work. You can currently `#[gazelle::ignore]` every usage of such a module. This can be cumbersome if the modules are used in many places. This PR introduces a lightweight option, `#[gazelle::provides(mod1, mod2, ...)]`, that allows the user to tell gazelle that a use or macro brings modules into scope. I'm open to additional options in the future. Topic: provides-directive
Owner
Author
|
Reviews in this chain: |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glob imports (e.g.
use some_crate::prelude::*) can introduce arbitrary modules, andgazelle has no way of tracking this. Similarly, macros can generate modules.
There are various ways one could imagine making this work. You can currently
#[gazelle::ignore]every usage of such a module. This can be cumbersome if themodules are used in many places.
This PR introduces a lightweight option,
#[gazelle::provides(mod1, mod2, ...)],that allows the user to tell gazelle that a use or macro brings modules into scope.
I'm open to additional options in the future.
Topic: provides-directive