Handle discovery of test-only modules correctly - #41
Merged
Conversation
Owner
Author
|
Reviews in this chain: |
This is a valid way to declare that a module is test-only: ``` #[cfg(test)] mod foobar; ``` Previously gazelle_rust ignored the `#[cfg(test)]` on the module and treated everything inside it as normal dependencies. This is only relevant for `generate_from_cargo` because we don't do module discovery in `pure_bazel` mode. This PR changes gazelle_rust_parser to return test-only extern mods separately and updates the language plugin to handle test-only mods correctly. Beyond propagating the test-only status of each module, we also need to walk modules in two passes because a module could be reachable through normal and test-only paths, in which case it should be treated as normal. Credit to @wolfd for discovering this issue and proposing the initial fix. This change was made with the assistance of LLM tooling. Topic: test-only-modules
Calsign
force-pushed
the
calsignlabs/revup/main/test-only-modules
branch
from
August 24, 2026 20:27
6b3aada to
bef228a
Compare
jason-rl
pushed a commit
to runloopai/gazelle_rust
that referenced
this pull request
Sep 2, 2026
…t-only-modules Handle discovery of test-only modules correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a valid way to declare that a module is test-only:
Previously gazelle_rust ignored the
#[cfg(test)]on the moduleand treated everything inside it as normal dependencies. This is
only relevant for
generate_from_cargobecause we don't do modulediscovery in
pure_bazelmode.This PR changes gazelle_rust_parser to return test-only extern
mods separately and updates the language plugin to handle
test-only mods correctly. Beyond propagating the test-only status
of each module, we also need to walk modules in two passes because
a module could be reachable through normal and test-only paths, in
which case it should be treated as normal.
Credit to @wolfd for discovering this issue and proposing the
initial fix.
This change was made with the assistance of LLM tooling.
Topic: test-only-modules