-
Notifications
You must be signed in to change notification settings - Fork 5
MAINT: switch pyvo obscore query with astroquery #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: switch pyvo obscore query with astroquery #125
Conversation
tutorials/spherex/spherex_intro.md
Outdated
| * `'spherex_qr'` -- the Quick Release Observations, for more information see [SPHEREx archive documentation at IRSA](). | ||
| * `'spherex_qr_cal'` -- the Quick Release Calibration products. | ||
| * `'spherex_qr_deep'` -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessworking here, @vandesai1 please provide guidence here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@troyraen - I'm still missing on this definitions/description
tutorials/spherex/spherex_intro.md
Outdated
| The `'access_url'` column is particularly important because it tells you how to access the data. Let's look at the `'access_url'` value for the first row: | ||
|
|
||
| ```{code-cell} ipython3 | ||
| results['access_url'][0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is draft as this line currently returns an incomplete HTTPS url rather than a datalink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to have been fixed, at least in the sense that it is now returning a full url instead of a relative path.
>>> results = Irsa.query_sia(pos=(coord, search_radius), collection='spherex_qr')
>>> results['access_url'][0]
'https://irsa.ipac.caltech.edu/ibe/data/spherex/qr/level2/2025W20_2D/l2b-v12-2025-176/6/level2_2025W20_2D_0444_1D6_spx_l2b-v12-2025-176.fits'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's great news!
88bd7da to
58143c5
Compare
|
@troyraen - this should be good to go now, I removed the DL explanations for now as we don't ship SIA with DL atm. (I expect some possibly unrelated failures, as something popped up in cron yesterday and I haven't yet looked into them closely) |
troyraen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
tutorials/spherex/spherex_intro.md
Outdated
| import pyvo | ||
| from astroquery.ipac.irsa import Irsa | ||
| from pyvo.dal.adhoc import DatalinkResults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this and also remove pyvo from the install cell.
| from astropy.coordinates import SkyCoord | ||
| import pyvo | ||
| from astroquery.ipac.irsa import Irsa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add astroquery to the install cell.
Co-authored-by: Troy Raen <[email protected]>
|
As I mentioned above, the rendering issues are unrelated, so I go ahead and look into them separately. |
This is TBD as IRSA SIA is not just yet returning datalinks