Skip to content

Spherex psf update #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2025
Merged

Spherex psf update #157

merged 2 commits into from
Oct 24, 2025

Conversation

@afaisst
Copy link
Contributor

@afaisst afaisst commented Oct 24, 2025 •
edited by troyraen
Loading

Closes IRSA-7402

Changes:

  • account for the fact that the PSF zone numbering is 1-indexed. Added a "-1" at the end to capture correct zone
  • modified text for PSF zone description
  • modified distance calculation (accounting for 1-indexed PSF zone centers)

@afaisst
Fix PSF extraction to use the previous plane
b73277a 
Adjusted PSF extraction to use the previous cube plane.
@afaisst
Refine PSF zone descriptions and distance calculation
914f52a 
Clarified the description of zone sizes and their arrangement in the PSF header. Updated the explanation for calculating distances to zone centers (subtract 1 from the PSF cutout centers).
@afaisst afaisst requested a review from troyraen October 24, 2025 18:29
@afaisst afaisst self-assigned this Oct 24, 2025
troyraen
troyraen approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@troyraen troyraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afaisst! LGTM and runs well on Fornax.

I note that the build-html failure is due to the fact that, as of today, SPHEREx QR1 data is no longer available through SIA. I'm updating the notebooks for QR2 in #153.

@bsipocz bsipocz added bug Something isn't working content: spherex Content related issues/PRs for notebooks with SPHEREx relevance labels Oct 24, 2025
@bsipocz bsipocz merged commit b6e3763 into main Oct 24, 2025
6 of 8 checks passed
@bsipocz bsipocz deleted the spherex-psf-update branch October 24, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

@troyraen troyraen troyraen approved these changes

Assignees

@afaisst afaisst

Labels

bug Something isn't working content: spherex Content related issues/PRs for notebooks with SPHEREx relevance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@afaisst @bsipocz @troyraen