Bug fix and update in calculation of PSF zones#293
Merged
Conversation
bsipocz
approved these changes
Mar 25, 2026
tutorials/spherex/spherex_psf.md
Outdated
| - name: Vandana Desai | ||
| - name: Jessica Krick | ||
| - name: Andreas Faisst | ||
| - name: "Brigitta Sip\u0151cz" |
Member
There was a problem hiding this comment.
Suggested change
| - name: "Brigitta Sip\u0151cz" | |
| - name: Brigitta Sipőcz |
tutorials/spherex/spherex_psf.md
Outdated
Comment on lines
+639
to
+642
|
|
||
| ```{code-cell} ipython3 | ||
|
|
||
| ``` |
Member
There was a problem hiding this comment.
Suggested change
| ```{code-cell} ipython3 | |
| ``` |
bsipocz
added
bug
troyraen
approved these changes
Mar 25, 2026
Contributor
troyraen
left a comment
troyraen
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Is jupyterlab changing the author metadata automatically?
Member
yes, I think so. It reorders the fields and messes up the encoding. It's on the level of being a papercut that I haven't yet explicitly reported it upstream to jupyterlab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the zone pixel coordinate centers are 0-based, their names in the header (XCTR_1, etc) are 1-based.
This has been clarified in the text. Furthermore, the formula for the calculation of the distance between pixel and PSF zone centers has been updated to account for 0-based indexing.
Linked to issue, closes #289