Fixes to BEAVRS input#153
Merged
valeriaRaffuzzi merged 3 commits intoCambridgeNuclear:mainfrom May 9, 2025
Merged
Conversation
Added in the BEAVRS model with the D-bank partially inserted. Also fixed a flaw in the geometry where the outermost cell was defined such that there could be a rare particle lost between it and the geometry boundary.
valeriaRaffuzzi
approved these changes
May 9, 2025
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
Looks good! I had BEAVRS fail after a hundred something cycles and I imagine it was due to this... luckily it was an easy fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEAVRS could occasionally lose particles at the edge of the geometry due to the outermost cell being defined with the geometry bounding surface. There are likely ways to delete this class of problem altogether in future, but for now I've simplified the cell definitions in BEAVRS. I've also added in the HZP BEAVRS input which I understand has the D-bank of rods partially inserted.