Conversation
mshadbolt
approved these changes
Feb 6, 2026
Contributor
mshadbolt
left a comment
There was a problem hiding this comment.
Works with clean rebuild and doesn't seem to affect any functionality
Seems like a good simplification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that I created many extra schema components related to DataDrsObjects and ContentsObjects that are not actually different from each other and just confusing to look at or comprehend.
Fundamentally, it is simpler to consider it this way:
This version consolidates the following:
AnalysisIndexContentsObject,AnalysisDataContentsObject,AnalysisContentsObject, andExperimentContentsObjectinto oneContentsObjectAnalysisDataDrsObjectandAnalysisIndexDrsObjectintoDataDrsObjectYou can check this by recomposing drs on a clean build and running the integration tests to see that ingest is not affected.
I can also confirm that I dumped the drs database on a build without these changes and then a build with these changes, and both were identical.