Conversation
OrdiNeu
approved these changes
Dec 4, 2025
Contributor
OrdiNeu
left a comment
OrdiNeu
left a comment
There was a problem hiding this comment.
Seems fine, haven't tested it though
| response = requests.get(url=f"{os.getenv("DRS_URL")}/ga4gh/drs/v1/objects/{experiment_id}", headers=headers) | ||
| response = requests.get(url=f"{os.getenv("DRS_URL")}/ga4gh/drs/v1/objects/{experiment_id}", headers=req_headers) | ||
| experiment_obj = None | ||
| if response.status_code == 200: |
Contributor
There was a problem hiding this comment.
NB: If the token times out during this request, the response.status check here can be inaccurate.
Member
Author
There was a problem hiding this comment.
Yes, but it seems pretty unlikely for the token to expire during this file handling (30 minutes) and I'm not sure it's worth it to catch the exceptional case...what do you think?
daisieh
force-pushed
the
daisieh/optimize
branch
from
ba8c419 to
d990d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this speeds much up, but it picks up the experiments endpoint from drs so that htsget only deals with the experiments, not all the drs objects. I also moved some service token calls so that they only happen once.