Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All vcf files will be indexed because the indexer actually looks at the file type of the file itself (line 638 of htsget_operations.py), but if the metadata is wrong, for example, categorizing a vcf file as a transcriptome:
we can get a key error where the variantfile that was indexed is present in the search hits, but the AnalysisDrsObject is not classed as a variant.
Probably the ideal solution is to prevent this sort of mismatched metadata from getting into the system, but in the meantime this fix prevents an error from being thrown in case something like this happens.